<html>
<head><meta charset="utf-8"><title>cicd · t-compiler/rust-analyzer · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/index.html">t-compiler/rust-analyzer</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/cicd.html">cicd</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="193874075"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/cicd/near/193874075" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> std::Veetaha <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/cicd.html#193874075">(Apr 14 2020 at 09:57)</a>:</h4>
<p>Is <a href="https://github.com/rust-analyzer/rust-analyzer/blob/c82e7696e6f86cc0843c5aab9f09b5d6dd0d4bac/.github/workflows/ci.yaml#L11" title="https://github.com/rust-analyzer/rust-analyzer/blob/c82e7696e6f86cc0843c5aab9f09b5d6dd0d4bac/.github/workflows/ci.yaml#L11"><code>CARGO_INCREMENTAL=0</code></a> option still needed to be explicit in our ci config?<br>
Doesn't <a href="https://github.com/rust-lang/cargo/pull/4065" title="https://github.com/rust-lang/cargo/pull/4065">this PR</a> fix the build time issue?</p>



<a name="193875621"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/cicd/near/193875621" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/cicd.html#193875621">(Apr 14 2020 at 10:11)</a>:</h4>
<p>Wouldn't that still build the <code>rust-analyzer</code> crates in incremental mode if we removed it? Though I'm not sure what's being cached exactly.</p>



<a name="193877450"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/cicd/near/193877450" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> std::Veetaha <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/cicd.html#193877450">(Apr 14 2020 at 10:30)</a>:</h4>
<p>I think <span class="user-mention" data-user-id="132829">@Christopher Durham</span>  can clarify on this probably?</p>



<a name="193924385"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/cicd/near/193924385" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christopher Durham <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/cicd.html#193924385">(Apr 14 2020 at 16:37)</a>:</h4>
<p>The TL;DR is that we don't want to build incremental on CI</p>



<a name="193924612"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/cicd/near/193924612" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christopher Durham <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/cicd.html#193924612">(Apr 14 2020 at 16:39)</a>:</h4>
<p>The cache for any builder is only populated the first time we build with that rustc/lockfile pair</p>



<a name="193924722"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/cicd/near/193924722" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christopher Durham <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/cicd.html#193924722">(Apr 14 2020 at 16:40)</a>:</h4>
<p>And we're also explicitly removing the artifacts for local crates</p>



<a name="193925003"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/cicd/near/193925003" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/cicd.html#193925003">(Apr 14 2020 at 16:42)</a>:</h4>
<p>Are we caching everything or just the dependencies? Ah, only deps, I looked up what <code>xtask pre-cache</code> does. Yeah, I think it's fine to leave <code>CARGO_INCREMENTAL=0</code> in there.</p>



<a name="193938925"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/cicd/near/193938925" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Christopher Durham <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/cicd.html#193938925">(Apr 14 2020 at 18:32)</a>:</h4>
<p>Another important note is that _we don't update caches incrementally_, even if we didn't have the pre-cache step, due to the way GHA caching works</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>